-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for Embedded Ansible and eliminate redundant spec code #14383
Conversation
5102197
to
c2465a8
Compare
Some comments on commits jameswnl/manageiq@eb6be29~...c2465a8 spec/support/ansible_shared/automation_manager/configuration_script.rb
spec/support/ansible_shared/automation_manager/job.rb
|
Checked commits jameswnl/manageiq@eb6be29~...c2465a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/support/ansible_shared/automation_manager/configuration_script_source.rb
spec/support/ansible_shared/automation_manager/credential.rb
spec/support/ansible_shared/provider.rb
|
@jrafanie this is the one I talked to you about. |
This is purely test refactoring and tests are passing, so... |
yay, it's gonna be a fun time extracting ansible into an external provider |
EmbeddedAnsible
fromAnsibleTower
EmbeddedAnsible
fromAnsibleTower
, there have been new enhancements added and the new specs are only coveringAnsibleTower
.This PR is to make the 2 sets of specs to use
shared_examples
to solve the above issues. Also make future enhancements easier to add test coverage without parity between the two.@miq-bot add_labels refactoring, test, providers/ansible_tower